[fix][broker][branch-2.10] Replace sync method call in async call chain to prevent ZK event thread deadlock #19539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ZK event thread deadlock Fixes apache#19536 Backports changes from apache#19015 to branch-2.10
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 16, 2023
…in to prevent ZK event thread deadlock (apache#19539) (cherry picked from commit b970f02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19536
Motivation
Please check #19536 for details about the problem this PR fixes.
Modifications
This backports changes from #19015 to branch-2.10 for replacing a sync method call in async call chain.
In addition, there's a test and an improvement to the #19015 solution which would attempt to execute the call
also for partitioned topics. I'll submit a separate PR to fix that issue in master / branch-2.11.
Documentation
docdoc-requireddoc-not-neededdoc-complete